feat: random drops #2486
Merged
feat: random drops #2486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandinocoder
force-pushed
the
ranges-drops
branch
from
e4a6c83 to
e415a36
Compare
WeylonSantana
force-pushed
the
ranges-drops
branch
from
e415a36 to
7959483
Compare
pandinocoder
requested changes
Jan 20, 2025
| public static LocalizedString dropremove = @"Remove"; | ||
|
|
||
| public static LocalizedString dropdisplay = @"{00} x{01} - {02}%"; | ||
| public static LocalizedString dropdisplay = @"{00} x{01} - {02} | {03}%"; |
Member
There was a problem hiding this comment.
Change to {00} x{01}-{02} | {03}%
| public static LocalizedString dropremove = @"Remove"; | ||
|
|
||
| public static LocalizedString dropdisplay = @"{00} x{01} - {02}%"; | ||
| public static LocalizedString dropdisplay = @"{00} x{01} - {02} | {03}%"; |
Member
There was a problem hiding this comment.
Change to {00} x{01}-{02} | {03}%
WeylonSantana
force-pushed
the
ranges-drops
branch
from
6756cca to
39854c3
Compare
Member
pandinocoder
left a comment
pandinocoder
left a comment
There was a problem hiding this comment.
I made a minor QoL change to the add button in frmNpc, it looks like frmResource just needs to be updated to match frmNpc and then this is good to go
pandinocoder
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2488
The default Amount for all games now becomes MaxQuantity in the logic of this pr, but nothing has been renamed. So after this pr, all games will drop a minimum of 1 - Amount when they update.
I'm also bringing the possibility of editing items that already exist in the drop list, both in the npcs and resources editor (I don't know why we didn't have this before)
Intersect_Client_impAbCh5M2.mp4